Add GPU project chipyard changes#2190
Merged
richardyrh merged 407 commits intoucb-bar:mainfrom Feb 21, 2025
Merged
Conversation
jerryz123
requested changes
Feb 10, 2025
generators/chipyard/src/main/scala/config/RadianceConfigs.scala
Outdated
Show resolved
Hide resolved
jerryz123
reviewed
Feb 10, 2025
Contributor
|
Cool, except this seems to break the ClusteredRocketConfig 😢 |
Contributor
|
chipsalliance/rocket-chip#3718 should fix this |
Contributor
|
Can you add a CI test that builds+runs one of these configs? The test can be something very simple... just a hello world-like thing basically. |
Contributor
|
Is using VCS an option? forgot our Vortex fails to build in Verilator |
Contributor
|
Oh, in that case don't bother with testing the sim. You can just add a test that the verilog gets generated. |
Verilator fails to build sim binary, so just generate verilog.
jerryz123
reviewed
Feb 20, 2025
jerryz123
approved these changes
Feb 21, 2025
Contributor
jerryz123
left a comment
jerryz123
left a comment
There was a problem hiding this comment.
I would ask you to add a docs page, but you can do that in a follow-on PR so we can get this monster in. Feel free to merge ... ignore the CI failures related to firesim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*for full list of labels:ci:fpga-deploy- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy- Build local FPGA bitstreams for platforms that are releasedci:disable- Disable CI